[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PULL for-2.0 00/11] Trivial patches for
From: |
Michael Tokarev |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PULL for-2.0 00/11] Trivial patches for 2014-04-08 |
Date: |
Tue, 08 Apr 2014 15:58:31 +0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131103 Icedove/17.0.10 |
08.04.2014 14:57, Markus Armbruster wrote:
> Peter Maydell <address@hidden> writes:
>
>> On 8 April 2014 09:52, Michael Tokarev <address@hidden> wrote:
>>> Well. At least one of them is entirely safe (hw/ide/ahci.c).
>>> Another - xbzrle.c - looks okay, and even maybe fixing a bug.
>>> And this int128 thing is okay too, except that the whole thing
>>> is questionable as has been mentioned in that thread.
>>>
>>> I can prepare another pull request without xbzrle and int128 changes,
>>> or even without ahci change too, but I'm not sure it is worth the
>>> effort - I think everything is okay to go. I'll take your word for this.
>>
>> Well, anything that goes in today is going to get at best two
>> days of being tested before the release. To me that argues
>> fairly strongly for not putting anything in unless it is
>> fixing a genuine bug.
>
> Seconded.
-trivial does not fix bugs. Only documentation bugs, which does
not met the above definition.
So no -trivial patches for 2.0 anymore.
Thanks,
/mjt
- [Qemu-trivial] [PULL 06/11] int128.h: Avoid undefined behaviours involving signed arithmetic, (continued)
- [Qemu-trivial] [PULL 06/11] int128.h: Avoid undefined behaviours involving signed arithmetic, Michael Tokarev, 2014/04/08
- [Qemu-trivial] [PULL 03/11] configure: Fix indentation of help for --enable/disable-debug-info, Michael Tokarev, 2014/04/08
- [Qemu-trivial] [PULL 09/11] configure: Remove redundant message for -Werror, Michael Tokarev, 2014/04/08
- [Qemu-trivial] [PULL 11/11] Fix grammar in comment, Michael Tokarev, 2014/04/08
- [Qemu-trivial] [PULL 08/11] scripts: add sample model file for Coverity Scan, Michael Tokarev, 2014/04/08
- [Qemu-trivial] [PULL 10/11] doc: grammify "allows to", Michael Tokarev, 2014/04/08
- Re: [Qemu-trivial] [Qemu-devel] [PULL for-2.0 00/11] Trivial patches for 2014-04-08, Peter Maydell, 2014/04/08