[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] tcg: Fix warning (1 bit signed bitfield entry
From: |
Richard Henderson |
Subject: |
Re: [Qemu-trivial] [PATCH] tcg: Fix warning (1 bit signed bitfield entry) and replace int by bool |
Date: |
Fri, 21 Feb 2014 13:10:06 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 02/21/2014 11:18 AM, Stefan Weil wrote:
> Static code analyzers complain about signed bitfields with only a single
> bit. is_ld is used as a boolean value, so make it bool.
>
> ppc64 already used bool for the 2nd argument is_ld of the local function
> add_qemu_ldst_label. Modify all other TCG targets to do follow this
> example.
>
> Signed-off-by: Stefan Weil <address@hidden>
> ---
> tcg/aarch64/tcg-target.c | 6 +++---
> tcg/arm/tcg-target.c | 6 +++---
> tcg/i386/tcg-target.c | 6 +++---
> tcg/ppc/tcg-target.c | 6 +++---
> tcg/tcg-be-ldst.h | 2 +-
> 5 files changed, 13 insertions(+), 13 deletions(-)
Applied to a tcg-next tree.
r~