[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH 03/13] qemu-socket: catch monitor_get_fd failu
From: |
Michael Tokarev |
Subject: |
Re: [Qemu-trivial] [PATCH 03/13] qemu-socket: catch monitor_get_fd failures |
Date: |
Fri, 21 Jun 2013 22:18:27 +0400 |
User-agent: |
Mozilla/5.0 (X11; Linux i686 on x86_64; rv:17.0) Gecko/20130529 Icedove/17.0.5 |
21.06.2013 14:38, Gerd Hoffmann wrote:
> case SOCKET_ADDRESS_KIND_FD:
> fd = monitor_get_fd(cur_mon, addr->fd->str, errp);
> + if (fd < 0) {
> + break;
> + }
> if (callback) {
> qemu_set_nonblock(fd);
> callback(fd, opaque);
case SOCKET_ADDRESS_KIND_FD:
fd = monitor_get_fd(cur_mon, addr->fd->str, errp);
- if (callback) {
+ if (fd >= 0 && callback) {
qemu_set_nonblock(fd);
callback(fd, opaque);
}
?
Thanks,
/mjt
- [Qemu-trivial] [PATCH 00/13] A bunch of little socket + chardev fixes, Gerd Hoffmann, 2013/06/21
- [Qemu-trivial] [PATCH 01/13] qemu-socket: zero-initialize SocketAddress, Gerd Hoffmann, 2013/06/21
- [Qemu-trivial] [PATCH 04/13] qemu-char: check optional fields using has_*, Gerd Hoffmann, 2013/06/21
- [Qemu-trivial] [PATCH 03/13] qemu-socket: catch monitor_get_fd failures, Gerd Hoffmann, 2013/06/21
- Re: [Qemu-trivial] [PATCH 03/13] qemu-socket: catch monitor_get_fd failures,
Michael Tokarev <=
- [Qemu-trivial] [PATCH 06/13] qemu-char: print notification to stderr, Gerd Hoffmann, 2013/06/21
- [Qemu-trivial] [PATCH 02/13] qemu-socket: drop pointless allocation, Gerd Hoffmann, 2013/06/21
- [Qemu-trivial] [PATCH 05/13] qemu-char: use more specific error_setg_* variants, Gerd Hoffmann, 2013/06/21
- [Qemu-trivial] [PATCH 09/13] qemu-char: use ChardevBackendKind in in CharDriver, Gerd Hoffmann, 2013/06/21
- [Qemu-trivial] [PATCH 08/13] qemu-char: don't leak opts on error, Gerd Hoffmann, 2013/06/21
- [Qemu-trivial] [PATCH 07/13] qemu-char: fix documentation for telnet+wait socket flags, Gerd Hoffmann, 2013/06/21
- [Qemu-trivial] [PATCH 11/13] qemu-char: add -chardev mux support, Gerd Hoffmann, 2013/06/21
- [Qemu-trivial] [PATCH 12/13] qemu-char: report udb backend errors, Gerd Hoffmann, 2013/06/21
- [Qemu-trivial] [PATCH 13/13] qemu-socket: don't leak opts on error, Gerd Hoffmann, 2013/06/21