Re: [Qemu-trivial] [PATCH trivial] configure: explicitly disable virtfs if softmmu=no

[Michael Tokarev]

11.06.2013 13:22, M. Mohan Kumar wrote:
> Michael Tokarev <address@hidden> writes:
> 
>> 11.06.2013 00:47, Michael Tokarev wrote:
>>> Or else
>>>
>>>  ./configure --disable-system --enable-virtfs
>>>
>>> (which makes no sense by its own but does not error out)
>>> will fail to build, because it will define CONFIG_VIRTFS,
>>> and the makefile will try to build virtfs-proxy-helper
>>> manpage (but not the executable).
>>
>> The build fails in this case in a separate build tree, because
                                ^^^^^^^^^^^^^^^^^^^^^^^^^
>> the fsdev directory is not created and scripts/texi2pod.pl
>> will be called with output = fsdev/virtfs-proxy-helper.pod,
>> which can't be created because fsdev/ does not exist.
>>
> 
> Hi,
> 
> I tried ./configure --disable-system --enable-virtfs and make. But didnt
> face any build failure. Could you please share your build failure
> information? virtfs-proxy-helper.1 is created inside the fsdev folder.

Well, it shouldn't be created to start with ;)

But the key component to this is to build in a separate
subdir:

 mkdir build
 cd build
 ../configure --disable-system --enable-virtfs
 make

this will fail.

It succeeds when run in the source tree because there,
fsdev/ dir does exist.  But in a separate build dir,
when system targets aren't enabled, it isn't created.

Thanks,

/mjt