[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PATCH 1/2] clean unnecessary code
From: |
Trival |
Subject: |
[Qemu-trivial] [PATCH 1/2] clean unnecessary code |
Date: |
Wed, 8 May 2013 17:46:19 +0800 |
Duplicates a string. If str is NULL it returns NULL, so
can make code simple.
Signed-off-by: Trival <address@hidden>
---
util/uri.c | 2 +-
vl.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/util/uri.c b/util/uri.c
index 4238729..e348c17 100644
--- a/util/uri.c
+++ b/util/uri.c
@@ -2162,7 +2162,7 @@ query_params_append (struct QueryParams *ps,
}
ps->p[ps->n].name = g_strdup(name);
- ps->p[ps->n].value = value ? g_strdup(value) : NULL;
+ ps->p[ps->n].value = g_strdup(value);
ps->p[ps->n].ignore = 0;
ps->n++;
diff --git a/vl.c b/vl.c
index 6e6225f..be0a93c 100644
--- a/vl.c
+++ b/vl.c
@@ -1215,7 +1215,7 @@ void add_boot_device_path(int32_t bootindex, DeviceState
*dev,
node = g_malloc0(sizeof(FWBootEntry));
node->bootindex = bootindex;
- node->suffix = suffix ? g_strdup(suffix) : NULL;
+ node->suffix = g_strdup(suffix);
node->dev = dev;
QTAILQ_FOREACH(i, &fw_boot_order, link) {
--
1.7.11.7
- [Qemu-trivial] [PATCH 1/2] clean unnecessary code,
Trival <=
- [Qemu-trivial] [PATCH 2/2] remove needless semicolon, Trival, 2013/05/08
- Re: [Qemu-trivial] [PATCH 2/2] remove needless semicolon, Michael Tokarev, 2013/05/08
- Re: [Qemu-trivial] [Qemu-devel] [PATCH 2/2] remove needless semicolon, Anthony Liguori, 2013/05/08
- Re: [Qemu-trivial] [Qemu-devel] [PATCH 2/2] remove needless semicolon, Michael Tokarev, 2013/05/09
- Re: [Qemu-trivial] [Qemu-devel] [PATCH 2/2] remove needless semicolon, Hu Tao, 2013/05/09
- Re: [Qemu-trivial] [Qemu-devel] [PATCH 2/2] remove needless semicolon, Peter Maydell, 2013/05/09
- Re: [Qemu-trivial] [Qemu-devel] [PATCH 2/2] remove needless semicolon, Dong Xu Wang, 2013/05/09
- Re: [Qemu-trivial] [Qemu-devel] [PATCH 2/2] remove needless semicolon, Andreas Färber, 2013/05/10
- Re: [Qemu-trivial] [Qemu-devel] [PATCH 2/2] remove needless semicolon, Anthony Liguori, 2013/05/10
Re: [Qemu-trivial] [PATCH 1/2] clean unnecessary code, Michael Tokarev, 2013/05/08