[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH 4/4] qemu/log.h: Fix missing incl
Re: [Qemu-trivial] [Qemu-devel] [PATCH 4/4] qemu/log.h: Fix missing includes
Mon, 28 Jan 2013 11:55:18 +0100
On Sat, 26 Jan 2013 12:54:36 -0800
Peter Crosthwaite <address@hidden> wrote:
> qemu/log.h needs a few bits and pieces from qemu-common to compile.
> Fixes the case where qemu/log.h is the first files included.
> Signed-off-by: Peter Crosthwaite <address@hidden>
> include/qemu/log.h | 1 +
> 1 file changed, 1 insertion(+)
> diff --git a/include/qemu/log.h b/include/qemu/log.h
> index 58f69cb..0a1266d 100644
> --- a/include/qemu/log.h
> +++ b/include/qemu/log.h
> @@ -2,6 +2,7 @@
> #define QEMU_LOG_H
> #include <stdarg.h>
> +#include "qemu-common.h"
Could you try to avoid including it header, and instead of move whatever
definitions it depends on to their proper places?
Reasoning for not including it in other headers, that it often creates circular
header dependencies of header that includes it is included in another header.
> #ifdef NEED_CPU_H
> #include "disas/disas.h"