[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] qemu-barrier: Fix compiler version check for
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-trivial] [PATCH] qemu-barrier: Fix compiler version check for future gcc versions |
Date: |
Fri, 5 Oct 2012 15:48:58 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Oct 03, 2012 at 11:11:02PM +0200, Stefan Weil wrote:
> The current check will give a wrong result for gcc-5.x with x < 4.
> Using QEMU_GNUC_PREREQ is simpler and fixes that issue.
>
> Signed-off-by: Stefan Weil <address@hidden>
> ---
>
> With current gcc versions (gcc-4.x) there is no problem.
> Nevertheless, I suggest to fix this in stable versions, too.
>
> Regards
>
> Stefan Weil
>
> qemu-barrier.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan