[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH v2] curses: don't initialize curses when qemu
From: |
Hitoshi Mitake |
Subject: |
Re: [Qemu-trivial] [PATCH v2] curses: don't initialize curses when qemu is daemonized |
Date: |
Sun, 23 Sep 2012 01:19:55 +0900 |
On Sun, Sep 23, 2012 at 1:06 AM, Stefan Hajnoczi <address@hidden> wrote:
> On Sat, Sep 15, 2012 at 01:15:41AM +0900, Hitoshi Mitake wrote:
>> Current qemu initializes curses even if -daemonize option is
>> passed. This cause problem because shell prompt appears without
>> calling endwin().
>>
>> This patch adds new function, is_daemonized(), to OS dependent
>> code. With this function, curses_display_init() can check that qemu is
>> daemonized or not. If daemonized, curses_display_init() isn't called
>> and the problem is avoided.
>>
>> Of course, -daemonize && -curses doesn't make sense. Users shouldn't
>> pass the arguments at the same time. But the problem is very painful
>> because Ctrl-C cannot be delivered to the terminal.
>>
>> Cc: Andrzej Zaborowski <address@hidden>
>> Cc: Stefan Hajnoczi <address@hidden>
>> Cc: Anthony Liguori <address@hidden>
>> Cc: Michael Roth <address@hidden>
>> Signed-off-by: Hitoshi Mitake <address@hidden>
>> ---
>>
>> v2: is_daemonized() is now called in main(), not in curses_display_init()
>>
>> 8<---
>> os-posix.c | 5 +++++
>> qemu-os-posix.h | 2 ++
>> qemu-os-win32.h | 5 +++++
>> vl.c | 3 ++-
>> 4 files changed, 14 insertions(+), 1 deletions(-)
>
> There has been no further discussion so this patch is ready to go. I
> have fixed up the coding style issues - please use scripts/checkpatch.pl
> next time (and see ./CODING_STYLE and ./HACKING).
Sorry for my coding style problems and thanks for your fix!
Thanks,
Hitoshi