[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] block: Don't forget to delete te
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH] block: Don't forget to delete temporary file |
Date: |
Wed, 05 Sep 2012 18:02:43 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) |
Paolo Bonzini <address@hidden> writes:
> Il 05/09/2012 15:26, address@hidden ha scritto:
>> From: Dunrong Huang <address@hidden>
>>
>> The caller would not delete temporary file after failed get_tmp_filename().
>>
>> Signed-off-by: Dunrong Huang <address@hidden>
>> ---
>> block.c | 6 +++++-
>> 1 个文件被修改,插入 5 行(+),删除 1 行(-)
>>
>> diff --git a/block.c b/block.c
>> index 074987e..2bc9f75 100644
>> --- a/block.c
>> +++ b/block.c
>> @@ -433,7 +433,11 @@ int get_tmp_filename(char *filename, int size)
>> return -EOVERFLOW;
>> }
>> fd = mkstemp(filename);
>> - if (fd < 0 || close(fd)) {
>> + if (fd < 0) {
>> + return -errno;
>> + }
>> + if (close(fd) != 0) {
>> + unlink(filename);
>> return -errno;
>> }
>> return 0;
>>
>
> Not necessary, mkstemp will not create a file if it returns an error.
Read the patch once more :)
Re: [Qemu-trivial] [Qemu-devel] [PATCH] block: Don't forget to delete temporary file, Kevin Wolf, 2012/09/11