[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] qemu-common: Declare qemu_irq ea

From: Stefan Weil
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] qemu-common: Declare qemu_irq earlier
Date: Fri, 24 Aug 2012 19:33:06 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20120724 Iceowl/1.0b1 Icedove/3.0.11

Am 24.08.2012 13:56, schrieb Stefan Hajnoczi:
On Fri, Aug 24, 2012 at 12:06 PM, Peter Maydell
<address@hidden>  wrote:
On 24 August 2012 11:54, Stefan Hajnoczi<address@hidden>  wrote:
On Mon, Aug 20, 2012 at 06:45:00AM +0200, Stefan Weil wrote:
This allows using qemu_irq in the target specific cpu.h.

Signed-off-by: Stefan Weil<address@hidden>
  qemu-common.h |    3 ++-
  1 files changed, 2 insertions(+), 1 deletions(-)

I'm not sure if there's a reason why qemu_irq was previously hidden from
cpu.h but the code change itself is fine and no one else has commented.

Thanks, applied to the trivial patches tree:

Consensus seemed to be that it was better to move qemu_irq
into hw/irq.h, as discussed in this mail thread:
rather than just doing a move of the typedef within this header.

Fine by me.  I won't send a pull request with this patch yet.

Stefan Weil: Are you happy to use the hw/irq.h patch instead of this?


Stefan H., that's OK.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]