[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH v3] console: Cleanup computation

From: BALATON Zoltan
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH v3] console: Cleanup computation of bytes per pixel and add missing cases
Date: Fri, 24 Aug 2012 17:24:32 +0200 (CEST)

On Fri, 24 Aug 2012, Stefan Hajnoczi wrote:
+    case 15:
+        pf.bits_per_pixel = 16; /* Is this correct? */

A trivial patch can't have "Is this correct?" parts :).

I already applied the simple and correct v2 patch.  Feel free to follow
up with additional cleanups but with resolved "Is this correct?" parts.

The v2 contained all my originally intended changes so it's fine with me. During review it was discovered that this part of code probably has more problems so I was trying to provide a fix for those in v3, and then checkpatch.pl complained about formatting too so I included a fix for that too. I can resend these broken up into too patches but as I wrote in the comment I have no way to test if these are correct. The above bits_per_pixel=16 for 15 bpp case was there already I just added a comment marking it as suspicious but I'm not sure how to resolve that.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]