[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] iov_send_recv(): Handle zero bytes case even
Re: [Qemu-trivial] [PATCH] iov_send_recv(): Handle zero bytes case even if OS does not
Mon, 13 Aug 2012 09:26:38 +0200
Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0
Am 12.08.2012 12:32, schrieb Michael Tokarev:
> On 12.08.2012 01:24, Peter Maydell wrote:
>> POSIX allows sendmsg() and recvmsg() to fail EMSGSIZE if passed a zero
>> msg.msg_iovlen (in particular the MacOS X implementation will do this).
>> Handle the case where iov_send_recv() is passed a zero byte count
>> explicitly, to avoid accidentally depending on the OS to treat zero
>> msg_iovlen as a no-op.
>> Signed-off-by: Peter Maydell <address@hidden>
>> This is what was causing 'make check' to fail on MacOS X.
>> The other option was to declare that a zero bytecount was illegal, I guess.
> Acked-by: Michael Tokarev <address@hidden>
> Kevin, does this fix the test-iov failure you're seeing on one of
> the build bots?
It's not on a build bot but on my test machine, but yes, this does fix
it indeed. Thanks for looking into it, Peter!