|
From: | Stefan Weil |
Subject: | Re: [Qemu-trivial] [Qemu-devel] [PATCH] configure: fix ALSA configure test |
Date: | Tue, 17 Jul 2012 21:24:07 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux i686; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 |
Am 17.07.2012 20:46, schrieb Peter Maydell:
On 17 July 2012 19:32, Stefan Weil <address@hidden> wrote:Hello Anthony, hello Blue, these patches fix broken builds, therefore I expected that they would be applied fast: http://patchwork.ozlabs.org/patch/171066/ http://patchwork.ozlabs.org/patch/171067/ http://patchwork.ozlabs.org/patch/171081/ http://patchwork.ozlabs.org/patch/171082/ The first of them fixes the ALSA problem.I think this is making it clearer that we should back out the Werror change in favour of something more narrowly targeted (although we may as well fix these warnings in test code anyway). Patch to follow... -- PMM
The arguments why -Werror is a bad idea for some configure tests are reasonable. Nevertheless the QEMU community was able to produce thousands of lines of code which compile without a warning, so we should be able to create warning and error free code for a handful of configure tests. The 4 patches above are valid and can be applied with or without -Werror, therefore qemu-trivial or whoever does not have to wait for Peter's patch. There is an ongoing discussion for the 3rd patch, so maybe patches 3 and 4 need to be delayed (they are less important because they are only needed for some older hosts which don't use -march=i868 by default). Regards, Stefan W.
[Prev in Thread] | Current Thread | [Next in Thread] |