Re: [Qemu-trivial] [Qemu-devel] [PATCH] vnc: Fix packed boolean struct members

[Stefan Hajnoczi]

On Sat, Feb 25, 2012 at 1:35 PM, Stefan Weil <address@hidden> wrote:
> This patch fixes warnings reported by splint:
>
> For variables which are packed in a single bit, a signed data type
> like 'int' does not make much sense.
>
> There is no obvious reason why the two values should be packed,
> so I removed the packing and changed the data type to bool
> because both are used as boolean values.
>
> Cc: Anthony Liguori <address@hidden>
> Signed-off-by: Stefan Weil <address@hidden>
> ---
>  ui/vnc-auth-sasl.h |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ui/vnc-auth-sasl.h b/ui/vnc-auth-sasl.h
> index fd9b18a..ee243a9 100644
> --- a/ui/vnc-auth-sasl.h
> +++ b/ui/vnc-auth-sasl.h
> @@ -37,9 +37,9 @@ typedef struct VncDisplaySASL VncDisplaySASL;
>  struct VncStateSASL {
>     sasl_conn_t *conn;
>     /* If we want to negotiate an SSF layer with client */
> -    int wantSSF :1;
> +    bool wantSSF;
>     /* If we are now running the SSF layer */
> -    int runSSF :1;
> +    bool runSSF;

I had to drop this patch from the trivial patches tree, it tickles a
new gcc warning.  Please resend with the necessary change.

I cannot reproduce it on my build host here with gcc Debian 4.6.2-12
but Anthony reports the following Ubuntu/Linaro 4.5.2-8ubuntu4:

  CC    ui/vnc-auth-sasl.o
cc1: warnings being treated as errors
/home/anthony/git/qemu/ui/vnc-auth-sasl.c: In function
‘vnc_sasl_client_cleanup’:
/home/anthony/git/qemu/ui/vnc-auth-sasl.c:34:9: error: suggest
parentheses around assignment used as truth value
make: *** [ui/vnc-auth-sasl.o] Error 1