qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH 2/2] cache-utils.h needs stdint.h


From: David Gibson
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH 2/2] cache-utils.h needs stdint.h for uintptr_t
Date: Thu, 8 Mar 2012 21:25:47 +1100
User-agent: Mutt/1.5.21 (2010-09-15)

On Thu, Mar 08, 2012 at 07:10:38AM +0100, Stefan Weil wrote:
> Am 08.03.2012 02:09, schrieb David Gibson:
> >cache-utils.h uses the C99 standard uintptr_t type.  However, that type
> >comes from stdint.h which is not #included before cache-utils.h in all
> >configurations.  This patch adds the necessary include to fix this.
> >
> >Signed-off-by: David Gibson<address@hidden>
> >---
> >  cache-utils.h |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> >
> >diff --git a/cache-utils.h b/cache-utils.h
> >index 04a6e2e..b0f1786 100644
> >--- a/cache-utils.h
> >+++ b/cache-utils.h
> >@@ -1,6 +1,8 @@
> >  #ifndef QEMU_CACHE_UTILS_H
> >  #define QEMU_CACHE_UTILS_H
> >
> >+#include<stdint.h>
> >+
> >  #if defined(_ARCH_PPC)
> >  struct qemu_cache_conf {
> >      unsigned long dcache_bsize;
> 
> The include statement is only needed for _ARCH_PPC.
> 
> See http://patchwork.ozlabs.org/patch/144763/ which
> fixes the same issue.

Ok, cool, didn't spot that one.

> Anthony, Blue, could someone please commit my patch?
> 
> Regards,
> 
> Stefan W.
> 

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson




reply via email to

[Prev in Thread] Current Thread [Next in Thread]