qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH] configure: Fix test for supported host CPU ty


From: Stefan Hajnoczi
Subject: Re: [Qemu-trivial] [PATCH] configure: Fix test for supported host CPU type
Date: Tue, 3 Jan 2012 10:50:58 +0000
User-agent: Mutt/1.5.21 (2010-09-15)

On Sat, Dec 24, 2011 at 01:07:25PM +0000, Peter Maydell wrote:
> The test for whether the host CPU is supported had several problems:
>  * the attempt to fall back to TCI was done as a duplicate
>    test, very late (so "--cpu foo" would fail early but "--cpu unicore32"
>    would fail late, differently, and after configure had already
>    printed a lot of output)
>  * a number of CPUs only supported as guests were included in the
>    list of CPUs we would accept as valid hosts, which would result
>    in a late compile failure on those systems rather than a
>    configure failure or fallback to TCI
>  * bailing out for an unsupported CPU happened before the main
>    option parsing, so "configure --help" wouldn't work
> 
> Fix these by folding the setting of ARCH into the first test for
> supported host CPU, removing spurious guest-only CPU names from it,
> and moving the "fall back to TCI" code earlier.
> 
> Signed-off-by: Peter Maydell <address@hidden>
> ---
>  configure |   44 +++++++++++++++++++++-----------------------
>  1 files changed, 21 insertions(+), 23 deletions(-)

Thanks, applied to the trivial patches -next tree:
https://github.com/stefanha/qemu/commits/trivial-patches-next

Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]