[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH 2/2] Makefile: use full path for
Re: [Qemu-trivial] [Qemu-devel] [PATCH 2/2] Makefile: use full path for qapi-generated directory
Thu, 1 Dec 2011 15:19:12 +0000
Alpine 2.00 (DEB 1167 2008-08-23)
On Wed, 30 Nov 2011, Stefan Weil wrote:
> It's common to use either out-of-tree builds or in-tree builds,
> but not to mix both variants with a common root directory.
> I think QEMU should explicitly forbid that mixed scenario (like
> other projects do).
> Even with your fix there can remain problems with generated
> header files.
Really? Can you provide more specific details?
> The mixed scenario creates unnecessary complexity.
> Without the mixed scenario, your patch is not needed.
I agree that supporting the mixed scenario shouldn't be a priority.
However without this last patch a "make clean" on the main tree is not
enough to allow out of tree builds.
Try the following scenario:
- cd qemu; ./configure; make
- make clean
- cd ../temp; ./configure --source-path=../qemu; make
this has to work, right? It does not without the patch to fix the
generation of config-devices.mak.
- Re: [Qemu-trivial] [Qemu-devel] [PATCH 2/2] Makefile: use full path for qapi-generated directory,
Stefano Stabellini <=