Re: [Qemu-trivial] [Qemu-devel] [PATCH 2/2] Makefile: use full path for qapi-generated directory

[Stefan Weil]

Am 30.11.2011 14:03, schrieb Stefano Stabellini:
> On Wed, 30 Nov 2011, Stefan Hajnoczi wrote:
> > On Tue, Nov 29, 2011 at 10:47 PM, Michael Roth
> > <address@hidden> wrote:
> > > Generally $(BUILD_DIR) == $(CURDIR), but that isn't necessarilly the
> > > case, so use $(BUILD_DIR)/qapi-generated for generated files to
> > > avoid potentionally sticking generating files in odd places outside
> > > the build's include paths.
> > > ---
> > > � Makefile | � � 2 +-
> > > � 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > Reviewed-by: Stefan Hajnoczi <address@hidden>
> >
> > Not applied to trivial tree yet. I want to let Stefano, Stefan Weil,
> > or Anthony take a look too since we were all discussing these changes
> > yesterday.
>
> While I think that the change is correct (certainly better than the
> original patch), unfortunately still doesn't solve the problem
> entirely.
> Steps to repro, assuming "qemu" is the source tree and "temp" is the
> empty build directory:
>
> - cd qemu; ./configure; make
>
> - cd ../temp; ./configure --source-path=../qemu; make
>
> Result:
>
> Makefile:9: config-devices.mak: No such file or directory
>
> In order to fix the issue, we need to make sure that config-devices.mak
> is relative to $(BUILD_DIR) in the Makefile.
>
> Signed-off-by: Stefano Stabellini <address@hidden>
>
> diff --git a/Makefile b/Makefile
[snip]

It's common to use either out-of-tree builds or in-tree builds,
but not to mix both variants with a common root directory.
I think QEMU should explicitly forbid that mixed scenario (like
other projects do).

Even with your fix there can remain problems with generated
header files. The mixed scenario creates unnecessary complexity.
Without the mixed scenario, your patch is not needed.

Regards,
Stefan Weil