[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PATCH 5/5] os-posix: Plug fd leak in qemu_create_pidfile
From: |
Markus Armbruster |
Subject: |
[Qemu-trivial] [PATCH 5/5] os-posix: Plug fd leak in qemu_create_pidfile() |
Date: |
Fri, 11 Nov 2011 10:40:09 +0100 |
Spotted by Coverity.
Signed-off-by: Markus Armbruster <address@hidden>
---
os-posix.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/os-posix.c b/os-posix.c
index dbf3b24..dc4a6bb 100644
--- a/os-posix.c
+++ b/os-posix.c
@@ -372,13 +372,16 @@ int qemu_create_pidfile(const char *filename)
return -1;
}
if (lockf(fd, F_TLOCK, 0) == -1) {
+ close(fd);
return -1;
}
len = snprintf(buffer, sizeof(buffer), FMT_pid "\n", getpid());
if (write(fd, buffer, len) != len) {
+ close(fd);
return -1;
}
+ close(fd);
return 0;
}
--
1.7.6.4
- [Qemu-trivial] [PATCH 0/5] Plug a few trivial resource leaks, Markus Armbruster, 2011/11/11
- [Qemu-trivial] [PATCH 2/5] ui: Plug memory leaks on parse_keyboard_layout() error path, Markus Armbruster, 2011/11/11
- [Qemu-trivial] [PATCH 3/5] qemu-sockets: Plug fd leak on unix_connect_opts() error path, Markus Armbruster, 2011/11/11
- [Qemu-trivial] [PATCH 5/5] os-posix: Plug fd leak in qemu_create_pidfile(),
Markus Armbruster <=
- [Qemu-trivial] [PATCH 1/5] qemu-char: Plug memory leak on qemu_chr_open_pty() error path, Markus Armbruster, 2011/11/11
- [Qemu-trivial] [PATCH 4/5] posix-aio-compat: Plug memory leak on paio_init() error path, Markus Armbruster, 2011/11/11
- Re: [Qemu-trivial] [Qemu-devel] [PATCH 0/5] Plug a few trivial resource leaks, Anthony Liguori, 2011/11/11