Re: [Qemu-trivial] [Qemu-devel] [PATCH] Correct and standardize header guards in all header files

[Stefan Hajnoczi]

On Sun, Jun 5, 2011 at 4:57 AM, Alexandre Raymond <address@hidden> wrote:
> diff --git a/balloon.h b/balloon.h
> index d478e28..4602d85 100644
> --- a/balloon.h
> +++ b/balloon.h
> @@ -11,8 +11,8 @@
>  *
>  */
>
> -#ifndef _QEMU_BALLOON_H
> -#define _QEMU_BALLOON_H
> +#ifndef QEMU_BALLOON_H
> +#define QEMU_BALLOON_H
>
>  #include "monitor.h"
>
> @@ -30,4 +30,4 @@ int do_info_balloon(Monitor *mon, MonitorCompletion cb, 
> void *opaque);
>  int do_balloon(Monitor *mon, const QDict *params,
>                MonitorCompletion cb, void *opaque);
>
> -#endif
> +#endif /* QEMU_BALOON_H */

BALOON?

> diff --git a/darwin-user/qemu.h b/darwin-user/qemu.h
> index b6d3e6c..a426381 100644
> --- a/darwin-user/qemu.h
> +++ b/darwin-user/qemu.h
> @@ -175,4 +175,4 @@ static inline uint64_t get_int64_arg(int *i, CPUPPCState 
> *cpu_env)
>  }
>  #endif
>
> -#endif
> +#endif /* GEMU_H */

GEMU, looks like darwin-user/qemu.h typoed "QEMU"?

If you really want to do this, please use a script to convert the code
consistently without errors.  I don't have time to review long
error-prone patches that have no external benefit for QEMU, sorry.

Stefan