[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] Correct and standardize header g
Re: [Qemu-trivial] [Qemu-devel] [PATCH] Correct and standardize header guards in all header files
Sun, 5 Jun 2011 18:37:04 +0300
On Sun, Jun 5, 2011 at 6:57 AM, Alexandre Raymond <address@hidden> wrote:
> As per ISO/IEC 9899, Section 7.1.3 on reserved identifiers,
> identifiers starting with an underscore are reserved.
> 1) Rename all incorrect header guards
> While I'm at it:
> 2) Standardize header guards to "#ifndef SOMETHING_H"
> 3) Repeat the header guard identifier after the closing "#endif"
Nice. Could you also standardize the path component, for example
hw/xyz.h -> HW_XYZ_H, or maybe rather QEMU_HW_XYZ_H?