Re: [PATCH] Fixes: Indentation using TABs and improve formatting

[Tanmay]

Sure, I'll do it!

Thanks,

Tanmay

On Mon, 6 May 2024 at 10:11, Thomas Huth <thuth@redhat.com> wrote:

On 04/05/2024 22.34, Michael Tokarev wrote:
> 04.05.2024 21:58, Tanmay wrote:
>> Hi,
>>
>> I have attached a patch file that fixes indentation and formatting for
>> some files as listed in https://gitlab.com/qemu-project/qemu/-/issues/373
>> <https://gitlab.com/qemu-project/qemu/-/issues/373>.
>
> it is sort of good you posted this patch to stable@.  It has absolutely
> nothing to do
> with stable, but it serves as a an example of things which should - in my
> opinion -
> not be done at all.

I disagree. Yes, clean-up patches like this make it somewhat difficult to
backport other patches to stable, but that should not be the reason to not
do cleanups at all. If we keep badly formatted code in the repository,
people will copy-n-paste it to other places, or if you have to do fixes in
sources that have mixed TABs and spaces, you often get complaints from
checkpatch.pl though it is not your fault. So we should get this straight at
one point in time.

So, Tanmay, could you please resend your patch, this time to
qemu-devel@nongnu.org instead of qemu-stable, and CC: qemu-arm@nongnu.org
and the corresponding ARM maintainers (you can use
scripts/get_maintainers.pl to find out the correct maintainers that should
be CC:-ed). And if possible, please send your patch inline and not as an
attachment (so it's possible to comment on the patch via hitting the reply
button), preferably with "git send-email" instead of using your e-mail program.

  Thanks!
   Thomas