[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-stable] [Qemu-block] [PATCH] block: Cleanup BMDS in bdrv_close
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-stable] [Qemu-block] [PATCH] block: Cleanup BMDS in bdrv_close_all |
Date: |
Tue, 5 Sep 2017 11:47:23 +0100 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Tue, Sep 05, 2017 at 11:28:44AM +0100, Stefan Hajnoczi wrote:
> On Wed, Aug 30, 2017 at 06:06:05PM +0800, Fam Zheng wrote:
> > This fixes the assertion due to op blockers added by BMDS:
> >
> > block.c:3248: bdrv_delete: Assertion `bdrv_op_blocker_is_empty(bs)' failed.
> >
> > Reproducer: simply start block migration and quit QEMU before it ends.
> >
> > Cc: address@hidden
> > Signed-off-by: Fam Zheng <address@hidden>
> > ---
> > block.c | 2 ++
> > migration/block.c | 2 +-
> > migration/block.h | 1 +
> > stubs/Makefile.objs | 1 +
> > stubs/block-migration.c | 6 ++++++
> > 5 files changed, 11 insertions(+), 1 deletion(-)
> > create mode 100644 stubs/block-migration.c
>
> Thanks, applied to my block tree:
> https://github.com/stefanha/qemu/commits/block
Dropped again pending the issue Kevin raised.
Stefan