Re: [Qemu-stable] [Qemu-devel] [PATCH v2] virtio: Move memory_listener_unregister to .unrealize

[Fam Zheng]

On Tue, 05/16 15:24, Fam Zheng wrote:
> The root cause of the crash is not obvious here, but the change
> regardlessly makes sense so it's proposed here: the listener was
> registered in .realize(), so do the cleanup in the matching .unrealize()
> rather than the .finalize() callback.

Actually it seem calling memory_listener_unregister in .instance_finalize is not
safe because it can be in the RCU thread.  This race is what caused the
corruption of the listener lists.

So I think this patch is doing the right thing.

Fam