Re: [Qemu-stable] [PATCH] virtio: fix HW_COMPAT_2_6 macro for virtio-*-pci drivers

[Michael S. Tsirkin]

On Tue, Dec 06, 2016 at 05:40:29PM -0200, Eduardo Habkost wrote:
> On Tue, Dec 06, 2016 at 09:36:07PM +0200, Michael S. Tsirkin wrote:
> > On Tue, Dec 06, 2016 at 05:33:49PM -0200, Eduardo Habkost wrote:
> > > On Tue, Dec 06, 2016 at 09:31:43PM +0200, Michael S. Tsirkin wrote:
> > > > On Tue, Dec 06, 2016 at 06:50:47PM +0100, Greg Kurz wrote:
> > > > > Since commit "9a4c0e220d8a hw/virtio-pci: fix virtio behaviour", 
> > > > > passing
> > > > > -device virtio-blk-pci.disable-modern=off has no effect on 2.6 machine
> > > > > types because the internal virtio-pci.disable-modern=on compat 
> > > > > property
> > > > > always prevail.
> > > > > 
> > > > > This should ideally be fixed in the qdev properties core code, but it 
> > > > > is
> > > > > too late in the QEMU 2.8 schedule. So this patch fixes the issue by 
> > > > > setting
> > > > > the compat properties for every virtio-*-pci subtypes instead of the 
> > > > > base
> > > > > virtio-pci type.
> > > > > 
> > > > > Signed-off-by: Greg Kurz <address@hidden>
> > > > 
> > > > What's the rush? Either the issue is or isn't 2.8 material. If it is,
> > > > let's fix it in qdev core now. If it isn't no need for quick fixes,
> > > > just wait a bit and merge qdev core fix after 2.8 is out.
> > > 
> > > Because it is a regression,
> > 
> > Regression in 2.7 though, isn't it?
> 
> Yes. Does that mean we don't mind leaving a regression unfixed in
> 2.8 because it was introduced in 2.7?

Not necessarily, it's a judgement call.  But there will always be
another release.  I would say don't rush it.


> -- 
> Eduardo