[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-stable] [PATCH] rules.mak: Also try -r to build modules
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-stable] [PATCH] rules.mak: Also try -r to build modules |
|
Date: |
Tue, 29 Nov 2016 17:57:04 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
On 29/11/2016 17:22, Stefan Hajnoczi wrote:
> On Tue, Nov 29, 2016 at 04:37:20PM +0100, Paolo Bonzini wrote:
>> Building qemu fails in distributions where gcc enables PIE by default
>> (e.g. Debian unstable) with:
>>
>> /usr/bin/ld: -r and -pie may not be used together
>>
>> You have to use -r instead of -Wl,-r to avoid gcc passing -pie to the linker
>> when PIE is enabled and a relocatable object is passed. However, clang
>> does not know about -r, so try -Wl,-r first.
>>
>> Reported-by: Adrian Bunk <address@hidden>
>> Cc: address@hidden
>> Signed-off-by: Paolo Bonzini <address@hidden>
>> ---
>> configure | 10 ++++++++--
>> rules.mak | 2 +-
>> 2 files changed, 9 insertions(+), 3 deletions(-)
>
> Thanks, applied to my staging tree:
> https://github.com/stefanha/qemu/commits/staging
Okay, then I'll send my pull request without this one.
Paolo