[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-stable] [PATCH v2 1/2] ivshmem: fix misconfig of not_legacy_32
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-stable] [PATCH v2 1/2] ivshmem: fix misconfig of not_legacy_32bit |
Date: |
Tue, 15 Nov 2016 05:48:34 -0500 (EST) |
Hi
----- Original Message -----
> From: ZhuangYanying <address@hidden>
>
> After commit 5400c02, ivshmem_64bit renamed to not_legacy_32bit,
> and changed the implementation of this property.
> Then use64 = 1, ~PCI_BASE_ADDRESS_MEM_TYPE_64 (default for ivshmem),
> the actual use is the legacy model,
> can not support greater than or equal 1G mapping,
> which is the opposite of configuration requirements.
>
> Cc: address@hidden
> Signed-off-by: Zhuang Yanying <address@hidden>
> Reviewed-by: Gonglei <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
> ---
> hw/misc/ivshmem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
> index 230e51b..b897685 100644
> --- a/hw/misc/ivshmem.c
> +++ b/hw/misc/ivshmem.c
> @@ -858,7 +858,7 @@ static void ivshmem_common_realize(PCIDevice *dev, Error
> **errp)
> pci_register_bar(dev, 0, PCI_BASE_ADDRESS_SPACE_MEMORY,
> &s->ivshmem_mmio);
>
> - if (!s->not_legacy_32bit) {
> + if (s->not_legacy_32bit) {
> attr |= PCI_BASE_ADDRESS_MEM_TYPE_64;
> }
>
> --
> 1.8.3.1
>
>
>