[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-stable] [PATCH] qemu/kvm_stat: Powerpc related fixes
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-stable] [PATCH] qemu/kvm_stat: Powerpc related fixes |
Date: |
Tue, 10 May 2016 13:58:25 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 |
On 19/04/2016 05:29, Hemant Kumar wrote:
> kvm_stat script is failing to execute on powerpc :
> # ./kvm_stat
> Traceback (most recent call last):
> File "./kvm_stat", line 825, in <module>
> main()
> File "./kvm_stat", line 813, in main
> providers = get_providers(options)
> File "./kvm_stat", line 778, in get_providers
> providers.append(TracepointProvider())
> File "./kvm_stat", line 416, in __init__
> self.filters = get_filters()
> File "./kvm_stat", line 315, in get_filters
> if ARCH.exit_reasons:
> AttributeError: 'ArchPPC' object has no attribute 'exit_reasons'
>
> This is because, its trying to access a non-defined attribute.
>
> Also, the IOCTL number of RESET is incorrect for powerpc. The correct
> number has been added.
>
> Signed-off-by: Hemant Kumar <address@hidden>
> ---
> scripts/kvm/kvm_stat | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/scripts/kvm/kvm_stat b/scripts/kvm/kvm_stat
> index 769d884..27d217a 100755
> --- a/scripts/kvm/kvm_stat
> +++ b/scripts/kvm/kvm_stat
> @@ -256,11 +256,13 @@ class ArchPPC(Arch):
> self.ioctl_numbers = IOCTL_NUMBERS
> self.ioctl_numbers['ENABLE'] = 0x20002400
> self.ioctl_numbers['DISABLE'] = 0x20002401
> + self.ioctl_numbers['RESET'] = 0x20002403
>
> # PPC comes in 32 and 64 bit and some generated ioctl
> # numbers depend on the wordsize.
> char_ptr_size = ctypes.sizeof(ctypes.c_char_p)
> self.ioctl_numbers['SET_FILTER'] = 0x80002406 | char_ptr_size << 16
> + self.exit_reasons = {}
>
> class ArchA64(Arch):
> def __init__(self):
>
Cc: address@hidden
Queued for 2.7 and 2.6.1, thanks.
Paolo
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-stable] [PATCH] qemu/kvm_stat: Powerpc related fixes,
Paolo Bonzini <=