Re: [Qemu-stable] [Qemu-devel] [PATCH v3 2/2] tests: update expected SSDT for floppy changes

[Igor Mammedov]

On Wed, 23 Dec 2015 20:20:54 +0300
Roman Kagan <address@hidden> wrote:

> On Wed, Dec 23, 2015 at 06:06:31PM +0300, Roman Kagan wrote:
> > On Wed, Dec 23, 2015 at 03:45:29PM +0200, Michael S. Tsirkin wrote:
> > > This is the actual vs expected diff with both patches applied.
> > 
> > Interesting...  The diff suggests that qemu running in your test
> > environment has no floppy drives
> 
> Actually, no.  My patch adds _FDE unconditionally, so I'm positively
> unable to tell how you could have obtained this result other than by
> not applying it.
> 
> > ... two 1.44M drives with bogus geometry for q35.
> 
> This one is a bug in my patch, indeed: I was tricked by FDRIVE_DRV_NONE
> being non-zero, and forgot to initialize the respective fields in
> acpi_get_misc_info() in case there is no floppy controller at all.
so instead of fake initialization, it's worth to make your patch
conditional on presence of controller after all.
i.e. add AML only if controller was present.

> 
> I'll resubmit with this bug fixed, but it has nothing to do with 
> the diff you're observing.
> 
> Roman.
>