[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-stable] [PATCH] exec-all: Translate TCI return addresses backw
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-stable] [PATCH] exec-all: Translate TCI return addresses backwards too |
Date: |
Tue, 18 Aug 2015 08:08:10 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
On 17/08/2015 20:28, Peter Crosthwaite wrote:
> This subtraction of return addresses applies directly to TCI as well as
> host-TCG. This fixes Linux boots for at least Microblaze, CRIS, ARM and
> SH4 when using TCI.
>
> Reviewed-by: Richard Henderson <address@hidden>
> Signed-off-by: Peter Crosthwaite <address@hidden>
> ---
> Changed since v1:
> Wrote commit message.
> ---
> include/exec/exec-all.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h
> index a6fce04..31c2405 100644
> --- a/include/exec/exec-all.h
> +++ b/include/exec/exec-all.h
> @@ -308,11 +308,7 @@ extern uintptr_t tci_tb_ptr;
> to indicate the compressed mode; subtracting two works around that. It
> is also the case that there are no host isas that contain a call insn
> smaller than 4 bytes, so we don't worry about special-casing this. */
> -#if defined(CONFIG_TCG_INTERPRETER)
> -# define GETPC_ADJ 0
> -#else
> # define GETPC_ADJ 2
> -#endif
>
> #define GETPC() (GETRA() - GETPC_ADJ)
>
>
Cc: address@hidden
- Re: [Qemu-stable] [PATCH] exec-all: Translate TCI return addresses backwards too,
Paolo Bonzini <=