[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-stable] [PATCH] qtest: Fix deadloop by running main loop AIO c
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-stable] [PATCH] qtest: Fix deadloop by running main loop AIO context's timers |
Date: |
Mon, 19 Jan 2015 10:29:30 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 |
On 16/01/2015 09:01, Fam Zheng wrote:
> qemu_clock_run_timers() only takes care of main_loop_tlg, we shouldn't
> forget aio timer list groups.
>
> Currently, the qemu_clock_deadline_ns_all (a few lines above) counts all
> the timergroups of this clock type, including aio tlg, but we don't fire
> them, so they are never cleared, which makes a dead loop.
>
> For example, this function hangs when trying to drive throttled block
> request queue with qtest clock_step.
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> cpus.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/cpus.c b/cpus.c
> index 3a5323b..dd7e595 100644
> --- a/cpus.c
> +++ b/cpus.c
> @@ -387,6 +387,7 @@ void qtest_clock_warp(int64_t dest)
> seqlock_write_unlock(&timers_state.vm_clock_seqlock);
>
> qemu_clock_run_timers(QEMU_CLOCK_VIRTUAL);
> + timerlistgroup_run_timers(&qemu_get_aio_context()->tlg);
Good catch. However, I think it's enough to run the QEMU_CLOCK_VIRTUAL
events, using timerlist_run_timers.
Thanks,
Paolo
> clock = qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL);
> }
> qemu_clock_notify(QEMU_CLOCK_VIRTUAL);
>