qemu-stable
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-stable] [PATCH] qga: Fix possible freed memory accessing


From: Eric Blake
Subject: Re: [Qemu-stable] [PATCH] qga: Fix possible freed memory accessing
Date: Thu, 18 Sep 2014 06:17:57 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0

On 09/17/2014 09:33 PM, zhanghailiang wrote:
> If readdir_r fails, error_setg_errno will reference the freed
> pointer *dirpath*.
> 
> Signed-off-by: zhanghailiang <address@hidden>
> ---
>  qga/commands-posix.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)

>      for (;;) {
>          if (readdir_r(dir, &entry, &result) != 0) {

Eww.  We're using readdir_r?  That's an inherently broken interface,
which can risk buffer overflow.  readdir should be preferred.

http://austingroupbugs.net/view.php?id=696

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]