[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-stable] [PULL 07/12] numa: show hex number in error message fo
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-stable] [PULL 07/12] numa: show hex number in error message for consistency and prefix them with 0x |
Date: |
Thu, 14 Aug 2014 21:22:14 +0200 |
On Thu, Aug 14, 2014 at 03:57:53PM -0300, Eduardo Habkost wrote:
> On Thu, Aug 14, 2014 at 06:09:03PM +0200, Michael S. Tsirkin wrote:
> > From: Hu Tao <address@hidden>
> >
> > The error messages before and after patch are:
> >
> > before:
> > qemu-system-x86_64: total memory for NUMA nodes (134217728) should equal
> > RAM size (20000000)
> >
> > after:
> > qemu-system-x86_64: total memory for NUMA nodes (0x8000000) should equal
> > RAM size (0x20000000)
>
> Why hex? Why not change both to decimal?
Reasonable number is usually very large and a power of 2,
hex is easier to read.
> --
> Eduardo