Re: [Qemu-stable] [PATCH] spapr_pci: Fix maximum IRQ number check in ibm, change-msi

[Alexander Graf]

On 29.04.14 05:17, Alexey Kardashevskiy wrote:
> Recently a check for maximum supported MSIX vectors number has been
> added. However the check always assumed that MSIX is the only case
> and failed on devices which have MSI but do not have MSIX such as
> QEMU's PCI Bridge. This results in assert in xics_alloc_block() as
> req_num is zero.
>
> This adds a check for MSI vectors number too.
>
> Signed-off-by: Alexey Kardashevskiy <address@hidden>
> ---
>
> I posted recently a memory corruption fix, patch
> "spapr_pci: Fix number of returned vectors in ibm, change-msi".
>
> However it breaks QEMU's PCI bridge so here is a patch.
>
> I would prepare a patch to replace the one in agrag/ppc-next ad01ba7
> but it has Cc: address@hidden in it so I am afraid it could make
> it to some other tree already (did not it?).
>
> Sorry for missing that. This is embarassing :(

You're lucky - the patch didn't get out of my queue yet. I've squashed 
this patch into the previous, broken commit and qemu-stable will only 
get CC'ed on the resulting, working patch.


Alex