Re: [Qemu-stable] [PATCH] rdma: fix error check

[Michael R. Hines]

On 08/23/2013 04:44 AM, Jie Yang wrote:

Error message is placed wrong place. It will never be printed to warn the user.

Signed-off-by: Frank Yang <address@hidden>

---

 migration-rdma.c | 6 +-----

 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/migration-rdma.c b/migration-rdma.c

index 3d1266f..968fbc1 100644

--- a/migration-rdma.c

+++ b/migration-rdma.c

@@ -1585,12 +1585,8 @@ static int qemu_rdma_post_send_control(RDMAContext *rdma, uint8_t *buf,

 

 

     if (ibv_post_send(rdma->qp, &send_wr, &bad_wr)) {

-        return -1;

-    }

-

-    if (ret < 0) {

         fprintf(stderr, "Failed to use post IB SEND for control!\n");

-        return ret;

+        return -1;

     }

 

     ret = qemu_rdma_block_for_wrid(rdma, RDMA_WRID_SEND_CONTROL, NULL);

-- 

1.8.3.msysgit.0

NACK:

This only partially fixes the bug, actually. Instead, please do the following:

/* many IB functions return positive errors, not negative errors */

ret = ibv_post_send(rdma->qp, &send_wr, &bad_wr));

if (ret > 0) {
    fprintf(stderr, "Failed to post IB SEND for control!\n");
    return -ret;
}

- Michael