[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-stable] [Qemu-devel] [PATCH 1/2] blockdev: do not default cach
From: |
Eric Blake |
Subject: |
Re: [Qemu-stable] [Qemu-devel] [PATCH 1/2] blockdev: do not default cache.no-flush to true |
Date: |
Thu, 19 Sep 2013 11:33:04 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 |
On 09/19/2013 10:48 AM, Paolo Bonzini wrote:
> That's why all my VMs were so fast lately. :)
>
> This changed in 1.6.0 by mistake in patch 29c4e2b (blockdev: Split up
> 'cache' option, 2013-07-18).
And my name is tied to that one as a reviewer. Sorry for letting it
through in the first place.
>
> Cc: address@hidden
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> blockdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <address@hidden>
>
> diff --git a/blockdev.c b/blockdev.c
> index 07dac05..76bfe30 100644
> --- a/blockdev.c
> +++ b/blockdev.c
> @@ -443,7 +443,7 @@ static DriveInfo *blockdev_init(QemuOpts *all_opts,
> if (qemu_opt_get_bool(opts, "cache.direct", false)) {
> bdrv_flags |= BDRV_O_NOCACHE;
> }
> - if (qemu_opt_get_bool(opts, "cache.no-flush", true)) {
> + if (qemu_opt_get_bool(opts, "cache.no-flush", false)) {
> bdrv_flags |= BDRV_O_NO_FLUSH;
> }
>
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature