[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-stable] [PATCH v2 3/3] xen_machine_pv: do not create a dummy C
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-stable] [PATCH v2 3/3] xen_machine_pv: do not create a dummy CPU in machine->init |
|
Date: |
Wed, 29 May 2013 14:29:51 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 |
Il 29/05/2013 14:11, Andreas Färber ha scritto:
>> xen_machine_pv uses cpu_x86_init, therefore it has been broken.
>>
>> This patch fixes the problem by removing the dummy CPU creation
>> altogether from xen_init_pv, relying on the fact that QEMU can now cope
>> with a machine without an emulated CPU.
>>
>> This fix should be backported to QEMU 1.5.
>>
>> Signed-off-by: Stefano Stabellini <address@hidden>
>> CC: address@hidden
>> CC: address@hidden
>
> Change looks okay,
>
> Reviewed-by: Andreas Färber <address@hidden>
>
> But for the future please avoid "this patch" in the commit message
> (because later on it's a "commit", not a patch) and also please put
> additional notices such as for backporting below the --- line.
I read it as a warning to backporters that the patch, even though it may
apply, was not tested and may even be wrong in 1.4.
Paolo