[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-stable] [PATCH] make_device_config.sh: Fix target path in gene
From: |
Michael Tokarev |
Subject: |
Re: [Qemu-stable] [PATCH] make_device_config.sh: Fix target path in generated dependency file |
Date: |
Sat, 27 Oct 2012 12:32:28 +0400 |
User-agent: |
Mozilla/5.0 (X11; Linux i686 on x86_64; rv:10.0.9) Gecko/20121015 Icedove/10.0.9 |
Ping?
/mjt
On 18.09.2012 18:32, Andreas Färber wrote:
> Am 18.09.2012 14:29, schrieb Michael Tokarev:
>> Has it been applied to anything? I don't think so.
>> Is it still needed?
>
> Not in qemu.git yet, still applicable AFAICT. CC'ing Paolo.
>
> /-F
>
>>
>> Thanks,
>>
>> /mjt
>>
>> On 07.06.2012 20:23, Andreas Färber wrote:
>>> config-devices.mak.d is included from Makefile.target, i.e. from inside
>>> the *-softmmu/ directory. It included the directory path, so never
>>> applied to the actual config-devices.mak. Symptoms were spurious
>>> dependency issues with default-configs/pci.mak.
>>>
>>> Fix by using `basename` to strip the directory path.
>>>
>>> Reported-by: Gerhard Wiesinger <address@hidden>
>>> Signed-off-by: Andreas Färber <address@hidden>
>>> ---
>>> Seems I forgot to send this out before 1.1...
>>>
>>> scripts/make_device_config.sh | 2 +-
>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/scripts/make_device_config.sh b/scripts/make_device_config.sh
>>> index 5d14885..0778fe2 100644
>>> --- a/scripts/make_device_config.sh
>>> +++ b/scripts/make_device_config.sh
>>> @@ -25,4 +25,4 @@ done
>>> process_includes $src > $dest
>>>
>>> cat $src $all_includes | grep -v '^include' > $dest
>>> -echo "$1: $all_includes" > $dep
>>> +echo "`basename $1`: $all_includes" > $dep
>>
>
>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-stable] [PATCH] make_device_config.sh: Fix target path in generated dependency file,
Michael Tokarev <=