[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [PATCH v3 11/20] Boot Linux Console Test: increase time
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [qemu-s390x] [PATCH v3 11/20] Boot Linux Console Test: increase timeout |
|
Date: |
Sat, 2 Mar 2019 22:43:52 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 |
On 2/21/19 1:57 AM, Cleber Rosa wrote:
> When running on very low powered environments, some tests may time out
> causing false negatives. As a conservative change, and for
> considering that human time (investigating false negatives) is worth
> more than some extra machine cycles (and time), let's increase the
> overall timeout.
However this is annoying when a test is stuck and you work on battery...
>
> CC: Alex Bennée <address@hidden>
> Signed-off-by: Cleber Rosa <address@hidden>
> ---
> tests/acceptance/boot_linux_console.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/acceptance/boot_linux_console.py
> b/tests/acceptance/boot_linux_console.py
> index cc5dcd7373..fa721a7355 100644
> --- a/tests/acceptance/boot_linux_console.py
> +++ b/tests/acceptance/boot_linux_console.py
> @@ -21,7 +21,7 @@ class BootLinuxConsole(Test):
> :avocado: enable
> """
>
> - timeout = 60
> + timeout = 90
>
> KERNEL_COMMON_COMMAND_LINE = 'printk.time=0 '
>
>