Re: [qemu-s390x] [PATCH v2 7/7] s390x/tcg: Implement LOAD COUNT TO BLOCK BOUNDARY

[Richard Henderson]

On 2/25/19 12:03 PM, David Hildenbrand wrote:
> Use a new CC helper to calculate the CC lazily if needed. While the
> PoP mentions that "A 32-bit unsigned binary integer" is placed into the
> first operand, there is no word telling that the other 32 bits (high
> part) are left untouched. Maybe the other 32-bit are unpredictable.
> So store 64 bit for now.
> 
> Bit magic courtesy of Richard.
> 
> Signed-off-by: David Hildenbrand <address@hidden>
> ---
>  target/s390x/cc_helper.c   |  8 ++++++++
>  target/s390x/helper.c      |  1 +
>  target/s390x/insn-data.def |  2 ++
>  target/s390x/internal.h    |  1 +
>  target/s390x/translate.c   | 19 +++++++++++++++++++
>  5 files changed, 31 insertions(+)

Reviewed-by: Richard Henderson <address@hidden>


r~