qemu-s390x
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [qemu-s390x] [PATCH 05/15] s390-bios: Factor finding boot device out


From: Jason J. Herne
Subject: Re: [qemu-s390x] [PATCH 05/15] s390-bios: Factor finding boot device out of virtio code path
Date: Mon, 11 Feb 2019 12:57:36 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1

On 2/4/19 5:45 AM, Cornelia Huck wrote:
On Tue, 29 Jan 2019 08:29:12 -0500
"Jason J. Herne" <address@hidden> wrote:

Make a new routine find_boot_device to locate the boot device for all
cases. not just virtio.

s/cases./cases,/


In one case no boot device is specified and a suitable boot device can not
be auto detected. The error message for this case was specific to virtio
devices. We update this message to remove virtio specific wording.

"The error message for the case where no boot device has been specified
and a suitable boot device cannot be auto detected was specific to
virtio devices. We update..."


Signed-off-by: Jason J. Herne <address@hidden>
---
  pc-bios/s390-ccw/main.c  | 87 ++++++++++++++++++++++++++----------------------
  tests/boot-serial-test.c |  2 +-
  2 files changed, 49 insertions(+), 40 deletions(-)

diff --git a/pc-bios/s390-ccw/main.c b/pc-bios/s390-ccw/main.c
index 7e3f65e..2457752 100644
--- a/pc-bios/s390-ccw/main.c
+++ b/pc-bios/s390-ccw/main.c
@@ -55,17 +55,18 @@ unsigned int get_loadparm_index(void)
   * NOTE: The global variable blk_schid is updated to contain the subchannel
   * information.
   */
-static bool find_dev(Schib *schib, int dev_no)
+static bool find_subch(int dev_no)

I'm wondering why you drop passing in the schib here? But OTOH, the
usage of global variables or not is a bit confused in the bios anyway...


I dropped it as an argument because the schib was never used outside of find_dev. Seems to make sense to make it a local variable in this case.

--
-- Jason J. Herne (address@hidden)




reply via email to

[Prev in Thread] Current Thread [Next in Thread]