[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [Qemu-devel] [PATCH v2 1/6] s390x/pci: Fix primary bus
Re: [qemu-s390x] [Qemu-devel] [PATCH v2 1/6] s390x/pci: Fix primary bus number for PCI bridges
Mon, 4 Feb 2019 17:58:18 -0500
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1
On 1/30/19 10:57 AM, David Hildenbrand wrote:
The primary bus number corresponds always to the bus number of the
bus the bridge is attached to.
Right now, if we have two bridges attached to the same bus (e.g. root
bus) this is however not the case. The first bridge will have primary
bus 0, the second bridge primary bus 1, which is wrong. Fix the assignment.
While at it, drop setting the PCI_SUBORDINATE_BUS temporarily to 0xff.
Setting it temporarily to that value (as discussed e.g. in ), is
only relevant for a running system that probes the buses. The value is
effectively unused for us just doing a DFS.
Also add a comment why we have to reassign during every reset (which I
found to be surprising.
Please note that hotplugging of bridges is in general still broken, will
be fixed next.
Reviewed-by: Thomas Huth <address@hidden>
Signed-off-by: David Hildenbrand <address@hidden>
Reviewed-by: Collin Walling <address@hidden>
|[Prev in Thread]
||[Next in Thread]|
- Re: [qemu-s390x] [Qemu-devel] [PATCH v2 1/6] s390x/pci: Fix primary bus number for PCI bridges,
Collin Walling <=