[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [qemu-s390x] [PATCH v2] s390x/tcg: Don't model FP registers as globa

From: David Hildenbrand
Subject: Re: [qemu-s390x] [PATCH v2] s390x/tcg: Don't model FP registers as globals
Date: Mon, 4 Feb 2019 18:41:42 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0

>>> Reading/writing a floating point register means reading/writing memory now.
>>> Break up ugly in2_x2() handling that modifies both, in1 and in2 into
>>> in1_x2l and in2_x2h. This makes things more readable. Also, in1_x1() is  
>> s/in1_x2l/in2_x2l/
>> s/in1_x2h/in2_x2h/
> Confused... it's already in2_x2h, I suppose that one should stay like
> it is?

Yes, I guess I am the confused one ;)

>> Sorry Conny, I assume when you pick this up, you can fix this up :)
> I would recommend a spell checker, only it would not help for the last
> case :)

I once tried to add a pre-commit hook  for that, but it didn't work that
reliably. And if it's not automated, I guess I will forget it again.

... as long as the code is not in a similar shape, we're fine ;)



David / dhildenb

reply via email to

[Prev in Thread] Current Thread [Next in Thread]