[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [qemu-s390x] [Qemu-devel] [PATCH] s390x/pci: mark zpci devices as un

From: Collin Walling
Subject: Re: [qemu-s390x] [Qemu-devel] [PATCH] s390x/pci: mark zpci devices as unmigratable
Date: Fri, 1 Feb 2019 10:41:10 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1

On 2/1/19 7:45 AM, Cornelia Huck wrote:
We currently don't migrate any state for zpci devices, which are
coupled with standard pci devices. This means funny things happen
when we e.g. try to migrate with a virtio-pci device but the s390x-
specific zpci state is not migrated (vfio-pci is not affected, as
it is not migratable anyway.)

Until this is fixed, mark zpci devices as unmigratable.

Reported-by: David Hildenbrand <address@hidden>
Signed-off-by: Cornelia Huck <address@hidden>

This is just a stop-gap measure to give us time to implement the
needed migration code properly.

I imagine this means we'll want a single migration handler that will
take care of PCI and zPCI in one go, that way the data stays coupled?

Just throwing thoughts out there.

  hw/s390x/s390-pci-bus.c | 10 ++++++++++
  1 file changed, 10 insertions(+)

diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c
index c96a7cba34..96c7c18f3f 100644
--- a/hw/s390x/s390-pci-bus.c
+++ b/hw/s390x/s390-pci-bus.c
@@ -1253,6 +1253,15 @@ static Property s390_pci_device_properties[] = {
+static const VMStateDescription s390_pci_device_vmstate = {
+    .name = TYPE_S390_PCI_DEVICE,
+    /*
+     * TODO: add state handling here, so migration works at least with
+     * emulated pci devices on s390x
+     */
+    .unmigratable = 1,
  static void s390_pci_device_class_init(ObjectClass *klass, void *data)
      DeviceClass *dc = DEVICE_CLASS(klass);
@@ -1263,6 +1272,7 @@ static void s390_pci_device_class_init(ObjectClass 
*klass, void *data)
      dc->bus_type = TYPE_S390_PCI_BUS;
      dc->realize = s390_pci_device_realize;
      dc->props = s390_pci_device_properties;
+    dc->vmsd = &s390_pci_device_vmstate;
static const TypeInfo s390_pci_device_info = {

Good band-aid patch.!

Reviewed-by: Collin Walling <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]