Re: [qemu-s390x] [PATCH v2 0/6] s390x/pci: remaining hot/un)plug patches

[Collin Walling]

On 1/30/19 10:57 AM, David Hildenbrand wrote:
> These are all the patches that are not yet upstream (@Conny you might
> already picked some, including them for the full picture) and after
> a good discussion yesterday, including a patch t get rid of the release
> timer. I ran a couple of sanity tests on this series.
>
> #1 and #2 fix hotplugging of PCI bridges.
> #3 warns when "zpci=off"
> #4 refactors unplugging
> #5 get's rid of the release timer
> #6 processes all unplug requests on reboot
>
> @Colin, can you review/ack? Especially Patch #4 is needed for qdev
> patches already on the list. ("[PATCH RFCv2 0/9] qdev: Hotplug handler
> chaining + virtio-pmem")

I've given my r-b for 4, 5, and 6. IIRC, the other patches in this
series looked fine from previous versions, but I'd like to look at them
more carefully before ack'ing. Please allow me some time to devote to
them in the near future. Trying my best to balance things :)

> David Hildenbrand (6):
>    s390x/pci: Fix primary bus number for PCI bridges
>    s390x/pci: Fix hotplugging of PCI bridges
>    s390x/pci: Warn when adding PCI devices without the 'zpci' feature
>    s390x/pci: Introduce unplug requests and split unplug handler
>    s390x/pci: Drop release timer and replace it with a flag
>    s390x/pci: Unplug remaining requested devices on pcihost reset
>
>   hw/s390x/s390-pci-bus.c | 233 ++++++++++++++++++++++++++--------------
>   hw/s390x/s390-pci-bus.h |   4 +-
>   2 files changed, 152 insertions(+), 85 deletions(-)