Re: [qemu-s390x] [Qemu-devel] [PATCH v1 for-2.13 1/4] pc-bios/s390-ccw/net: Split up net_load() into init, load and uninit parts

[Thomas Huth]

On 18.04.2018 20:11, Farhan Ali wrote:
> 
> 
> On 04/18/2018 08:31 AM, Thomas Huth wrote:
>> When we want to support pxelinux-style network booting later, we've got
>> to do several TFTP transfers - and we do not want to apply for a new IP
>> address via DHCP each time. So split up net_load into three parts:
>>
>> 1. net_init(), which initializes virtio-net, gets an IP address via DHCP
>>     and prints out the related information.
>>
>> 2. The tftp_load call is now moved directly into the main() function
>>
>> 3. A new net_uninit() function which should tear down the network stack
>>     before we are done in the firmware.
>>
>> This will make it easier to extend the code in the next patches.
>>
>> Signed-off-by: Thomas Huth<address@hidden>
> 
> 
> Just a minor nit, if we could rename *_uninit functions to
> destroy/release? I think it's just easier to read

Sure. Completely unrepresentative statistics from my QEMU repository:

$ grep -r uninit . | wc -l
212
$ grep -r destroy . | wc -l
904
$ grep -r release . | wc -l
1133

So I think I'll go with "release".

 Thomas