[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [PATCH v1] s390x/kvm: cleanup calls to cpu_synchronize_
From: |
Thomas Huth |
Subject: |
Re: [qemu-s390x] [PATCH v1] s390x/kvm: cleanup calls to cpu_synchronize_state() |
Date: |
Thu, 12 Apr 2018 19:50:21 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 12.04.2018 11:35, David Hildenbrand wrote:
> We have a call to cpu_synchronize_state() on every kvm_arch_handle_exit().
>
> Let's remove the ones that are no longer needed.
>
> Remaining places (for s390x) are in
> - target/s390x/sigp.c, on the target CPU
> - target/s390x/cpu.c:s390_cpu_get_crash_info()
>
> While at it, use kvm_cpu_synchronize_state() instead of
> cpu_synchronize_state() in KVM code. (suggested by Thomas Huth)
>
> Signed-off-by: David Hildenbrand <address@hidden>
> ---
> hw/s390x/s390-pci-inst.c | 8 --------
> target/s390x/kvm.c | 20 +-------------------
> 2 files changed, 1 insertion(+), 27 deletions(-)
Wow, that was really a mess, looking at which different "levels" the
cpu_synchronize_state was done before. Good that you cleaned it up now.
Reviewed-by: Thomas Huth <address@hidden>