[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [PATCH v1 for-2.12 1/2] s390x/mmu: don't overwrite pend
From: |
Thomas Huth |
Subject: |
Re: [qemu-s390x] [PATCH v1 for-2.12 1/2] s390x/mmu: don't overwrite pending exception in mmu translate |
Date: |
Mon, 9 Apr 2018 13:44:45 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 09.04.2018 13:30, David Hildenbrand wrote:
> If we already triggered another exception, don't overwrite it with a
> protection exception.
>
> Signed-off-by: David Hildenbrand <address@hidden>
> ---
> target/s390x/mmu_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/s390x/mmu_helper.c b/target/s390x/mmu_helper.c
> index 1deeb6e6e4..a25deef5dd 100644
> --- a/target/s390x/mmu_helper.c
> +++ b/target/s390x/mmu_helper.c
> @@ -325,7 +325,7 @@ static int mmu_translate_asce(CPUS390XState *env,
> target_ulong vaddr,
>
> r = mmu_translate_region(env, vaddr, asc, asce, level, raddr, flags, rw,
> exc);
> - if (rw == MMU_DATA_STORE && !(*flags & PAGE_WRITE)) {
> + if (!r && rw == MMU_DATA_STORE && !(*flags & PAGE_WRITE)) {
> trigger_prot_fault(env, vaddr, asc, rw, exc);
> return -1;
> }
Looks right.
Reviewed-by: Thomas Huth <address@hidden>
- [qemu-s390x] [PATCH v1 for-2.12 0/2] s390x/kvm: last minute fixes, David Hildenbrand, 2018/04/09
- [qemu-s390x] [PATCH v1 for-2.12 2/2] s390x: load_psw() should only exchange the PSW for KVM, David Hildenbrand, 2018/04/09
- Re: [qemu-s390x] [PATCH v1 for-2.12 2/2] s390x: load_psw() should only exchange the PSW for KVM, Christian Borntraeger, 2018/04/09
- Re: [qemu-s390x] [PATCH v1 for-2.12 2/2] s390x: load_psw() should only exchange the PSW for KVM, David Hildenbrand, 2018/04/09
- Re: [qemu-s390x] [PATCH v1 for-2.12 2/2] s390x: load_psw() should only exchange the PSW for KVM, Christian Borntraeger, 2018/04/09
- Re: [qemu-s390x] [PATCH v1 for-2.12 2/2] s390x: load_psw() should only exchange the PSW for KVM, David Hildenbrand, 2018/04/09
- Re: [qemu-s390x] [PATCH v1 for-2.12 2/2] s390x: load_psw() should only exchange the PSW for KVM, Christian Borntraeger, 2018/04/09
- Re: [qemu-s390x] [PATCH v1 for-2.12 2/2] s390x: load_psw() should only exchange the PSW for KVM, Cornelia Huck, 2018/04/09
Re: [qemu-s390x] [PATCH v1 for-2.12 2/2] s390x: load_psw() should only exchange the PSW for KVM, Thomas Huth, 2018/04/09
[qemu-s390x] [PATCH v1 for-2.12 1/2] s390x/mmu: don't overwrite pending exception in mmu translate, David Hildenbrand, 2018/04/09
Re: [qemu-s390x] [PATCH v1 for-2.12 0/2] s390x/kvm: last minute fixes, Cornelia Huck, 2018/04/09