Re: [Qemu-riscv] [PATCH V2] RISC-V: fix single stepping over ret and other branching instructions

[Richard Henderson]

On 3/25/19 4:45 AM, Fabien Chouteau wrote:
> This patch introduces wrappers around the tcg_gen_exit_tb() and
> tcg_gen_lookup_and_goto_ptr() functions that handle single stepping,
> i.e. call gen_exception_debug() when single stepping is enabled.
> 
> Theses functions are then used instead of the originals, bringing single
> stepping handling in places where it was previously ignored such as jalr
> and system branch instructions (ecall, mret, sret, etc.).
> 
> Signed-off-by: Fabien Chouteau <address@hidden>
> ---
>  .../riscv/insn_trans/trans_privileged.inc.c   |  8 ++---
>  target/riscv/insn_trans/trans_rvi.inc.c       |  6 ++--
>  target/riscv/translate.c                      | 30 +++++++++++++++----
>  3 files changed, 32 insertions(+), 12 deletions(-)

Reviewed-by: Richard Henderson <address@hidden>


r~