[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH 1/2] monitor: Add dump-stack command
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PATCH 1/2] monitor: Add dump-stack command |
Date: |
Wed, 08 May 2019 15:10:45 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
"Dr. David Alan Gilbert" <address@hidden> writes:
> * Markus Armbruster (address@hidden) wrote:
>> Suraj Jitindar Singh <address@hidden> writes:
>>
>> > Add a monitor command "dump-stack" to be used to dump the stack for the
>> > current cpu.
>>
>> I guess this is just for debugging. Correct?
>>
>> Shouldn't this be "info stack", to match "info registers" and "info
>> cpustats"?
>
> Since this is primarily about walking the guests stack frames and not
> walking qemu internal data structures, I think it's probably OK to be
> a dump-stack rather than an info subcommand.
Well, "info registers" is also about the guest's state and not QEMU
internal state. Arguably, so are "info pic", "info tlb", ...
We have a long-standing tradition of using "info" for "pure"
information-retrieving commands. I rather like that pattern.
Ultimately your choice as the HMP maintainer, of course.
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 2/2] ppc: Add dump-stack implementation, (continued)
Re: [Qemu-ppc] [PATCH 2/2] ppc: Add dump-stack implementation, Greg Kurz, 2019/05/02
Re: [Qemu-ppc] [Qemu-devel] [PATCH 2/2] ppc: Add dump-stack implementation, Markus Armbruster, 2019/05/07
Re: [Qemu-ppc] [PATCH 1/2] monitor: Add dump-stack command, Dr. David Alan Gilbert, 2019/05/01
Re: [Qemu-ppc] [PATCH 1/2] monitor: Add dump-stack command, David Gibson, 2019/05/01
Re: [Qemu-ppc] [Qemu-devel] [PATCH 1/2] monitor: Add dump-stack command, Markus Armbruster, 2019/05/07